Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Standard Hub deployment to create regional AKS and ACR private DNS zones #1306

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Updating Standard Hub deployment to create regional AKS and ACR private DNS zones #1306

merged 3 commits into from
Jul 31, 2024

Conversation

hatboyzero
Copy link
Collaborator

Updating Standard Hub deployment to create regional AKS and ACR private DNS zones

Details on the issue fix or feature implementation

Updating Standard Hub deployment to create regional AKS and ACR private DNS zones. This is meant to mitigate private endpoint DNS resolution for deployments in regions outside of the region where the hub VNET resides.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have included inline docs for my changes, where applicable
  • I have successfully run a local build
  • I have provided the required update scripts, where applicable
  • I have updated relevant docs, where applicable

@jamesrcounts jamesrcounts marked this pull request as draft July 31, 2024 14:35
jamesrcounts
jamesrcounts approved these changes Jul 31, 2024
View reviewed changes
deploy/standard-hub/infra/main.bicep Outdated Show resolved Hide resolved
@hatboyzero hatboyzero marked this pull request as ready for review July 31, 2024 14:40
@hatboyzero hatboyzero marked this pull request as draft July 31, 2024 14:48
@hatboyzero hatboyzero marked this pull request as ready for review July 31, 2024 15:58
@ciprianjichici ciprianjichici merged commit ea2c8a1 into main Jul 31, 2024
9 checks passed
@ciprianjichici ciprianjichici deleted the mg-hub-dns-update branch July 31, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciprianjichici ciprianjichici ciprianjichici approved these changes

@jamesrcounts jamesrcounts jamesrcounts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hatboyzero @jamesrcounts @ciprianjichici